feat: euclid v2 #158
Open
feat: euclid v2 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #158 will not alter performanceComparing Summary
|
greged93
reviewed
Feb 18, 2025
There was a problem hiding this comment.
Thank you for the help on this! I think we might be missing modifications to the following related to Euclid:
ScrollHardforkInfofor struct itself.ScrollHardforkforscroll_mainnetandscroll_sepolia.impl From<Genesis> for ScrollChainSpecfor the Euclid changes.
| @@ -107,6 +110,7 @@ impl ScrollHardfork { | |||
| Self::Curie => Some(7096836), | |||
| Self::Darwin => Some(8568134), | |||
| Self::DarwinV2 => Some(8923772), | |||
| _ => None, | |||
There was a problem hiding this comment.
Should we have Self::Euclid and Self::EuclidV2 as Some(0)?
There was a problem hiding this comment.
I think that's something TBD?
Some(0) means enabled on the genesis which should not be as expected?
There was a problem hiding this comment.
oh right, maybe just add a TODO?
greged93
reviewed
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #143